Re: CVS commit: pkgsrc/devel/glib2

[Katarzyna Ciarcińska <kasia%albedo.art.pl@localhost>]

No idea really.

First of all, only 32-bit libiconv has both symbols, 64-bit version has only 
iconv_open():

% nm -arch i386 /usr/lib/libiconv.2.dylib | grep iconv_open
00012d1b T _iconv_open
00013ddf T _libiconv_open
% nm -arch x86_64 /usr/lib/libiconv.2.dylib | grep iconv_open
0000000000013171 T _iconv_open

Second:

% cd pkgsrc/devel/glib2
% % bmake -V '${ICONV_TYPE}'
gnu
% bmake -V '${USE_BUILTIN.iconv}'
yes
% bmake -V '${IS_BUILTIN.iconv}'
yes

Which is contrary to converters/libiconv/bultin.mk, which seems to be wrong:

.if !defined(ICONV_TYPE)
ICONV_TYPE?=    gnu
.  if !empty(USE_BUILTIN.iconv:M[yY][eE][sS]) && \
      !empty(IS_BUILTIN.iconv:M[nN][oO])
ICONV_TYPE=     native
.  endif
.endif

My guess is, there's something wrong with auto-detecting built-in libiconv on 
Darwin (maybe other platforms too).

The above is on both Lion and Mountain Lion.

Kind regards,
Adam


> Then, why PR 46720 is happened?
> 
> On Fri, 07 Sep 2012 20:43:54 +0900, Adam Ciarcinski 
> <adam%netbsd.org@localhost> wrote:
> 
>> Module Name: pkgsrc
>> Committed By:        adam
>> Date:                Fri Sep  7 11:43:54 UTC 2012
>> 
>> Modified Files:
>>      pkgsrc/devel/glib2: hacks.mk
>> 
>> Log Message:
>> Darwin always needs iconv hack
>> 
>> 
>> To generate a diff of this commit:
>> cvs rdiff -u -r1.7 -r1.8 pkgsrc/devel/glib2/hacks.mk
>> 
>> Please note that diffs are not public domain; they are subject to the
>> copyright notices on the relevant files.
>> 
>> 
> 
> 
> -- 
> OBATA Akio / obache%NetBSD.org@localhost