Re: CVS commit: pkgsrc/devel/gettext-lib

[Ryo ONODERA <ryo_on%yk.rim.or.jp@localhost>]

From: Ryo ONODERA <ryo_on%yk.rim.or.jp@localhost>, Date: Sat, 01 Sep 2012 
05:10:11 +0900 (JST)

> Hi,
> 
> From: John Marino <netbsd%marino.st@localhost>, Date: Fri, 31 Aug 2012 
> 19:44:57 +0200
> 
>> On 8/29/2012 11:01, Steven Drake wrote:
>>> Module Name:        pkgsrc
>>> Committed By:       sbd
>>> Date:               Wed Aug 29 09:01:01 UTC 2012
>>>
>>> Modified Files:
>>>     pkgsrc/devel/gettext-lib: Makefile PLIST buildlink3.mk
>>>
>>> Log Message:
>>> Problem:
>>>
>>> 1) The libintl.h from gettext-lib renames the gettext functions so
>>> that
>>>     they are prefixed with 'libintl_' (So that the functions named in
>>>     libintl don't conflict with any that maybe in libc).
>>>
>>> 2) gettext-tools is _always_ built with gettext-lib.
>>>
>>> 3) The tools architecture may make gettext-tools a build dependence or
>>>     someone may choose to install gettext-tools.
>>>
>>> 4) The OS has built in gettext.
>>>
>>> 5) For some reason ${PREFIX}/include is add to the compiler search
>>> path and
>>>     libintl.h from gettext-lib is found before the system one.
>>>
>>> The result is that all the gettext functions are renamed to have the
>>> 'libintl_' prefix but libintl is not linked with and the following
>>> happens:
>>>
>>> ${FILENAME}: undefined reference to `libintl_gettext'
>>> ${FILENAME}: undefined reference to `libintl_textdomain'
>>> ${FILENAME}: undefined reference to `libintl_bindtextdomain'
>>> collect2: error: ld returned 1 exit status
>>>
>>> Solution:
>>> Hide libintl.h from gettext-lib in ${PREFIX}/include/gettext then add
>>> that
>>> to the compiler search path when realy needed.
>>>
>>> This should permanently fix PR's pkg/24326 pkg/36201 pkg/40153
>>> pkg/43129
>>> pkg/44009 and pkg/44016.
>>>
>>> Bump PKGREVISION.
>>>
>> 
>> I just started a full bulkbuild that is 1800 packages in and I think I
>> already see a regression due to this.
>> 
>> devel/php-gettext: Configure: error: Cannot locate header file
>> libintl.h
>> 
>> Is there something wrong with php-gettext or this gettext-lib change?
> 
> On DragonFly 3.0.1(that uses gettext from pkgsrc, and native gcc 4.4.7),
> I have gotten the following errors (cases of normal bmake run
> and bmake -d e) on devel/gobject-introspection.
> 
> It seems that -I/usr/pkg/include/gettext is not utilized.

Modifying glib-2.0.pc's Cflags: line to add -I/usr/pkg/include/gettext
helps me.
Automated mechanism of overriding .pc file is required?

--
Ryo ONODERA // ryo_on%yk.rim.or.jp@localhost
PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3