pkgsrc-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: pkgsrc/net/coda

On 7/22/2012 05:20, David A. Holland wrote:
Module Name:    pkgsrc
Committed By:   dholland
Date:           Sun Jul 22 03:20:04 UTC 2012

Modified Files:
        pkgsrc/net/coda: Makefile distinfo

Log Message:
Improve previous patch: blindly setting MAXNAMLEN to 255 is dangerous,
as it is e.g. 511 on NetBSD. Instead, get it from NAME_MAX, which is
POSIX. PKGREVISION ->  3 as a precaution.

To generate a diff of this commit:
cvs rdiff -u -r1.12 -r1.13 pkgsrc/net/coda/Makefile
cvs rdiff -u -r1.8 -r1.9 pkgsrc/net/coda/distinfo
cvs rdiff -u -r1.1 -r1.2 \

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

I don't have any comment to the patch itself as it is an improvement. However, any system other than dragonfly that doesn't have MAXNAMLEN defined is still going to fail to build* -- the patch to is very gross, but it saved having to patch about half a dozen files. To really do this in a generic way, we probably need to remove the patch and duplicate the fix to every file that mentions MAXNAMLEN. Maybe a better way is to create one header to defined MAXNAMLEN (if necessary) and add that header to every file that needs it.


* Honestly, any system not specifically supported by coda will probably fail to build even if MAXNAMLEN is fixed -- there are other platform specific code that will probably cause a build failure if the right conditional branch isn't presented.

Home | Main Index | Thread Index | Old Index