Re: CVS commit: pkgsrc/sysutils/e2fsprogs

[David Holland <dholland-pkgchanges%netbsd.org@localhost>]

On Wed, Jun 27, 2012 at 11:46:19PM +0200, Joerg Sonnenberger wrote:
 > > Modified Files:
 > >    pkgsrc/sysutils/e2fsprogs: distinfo
 > > Added Files:
 > >    pkgsrc/sysutils/e2fsprogs/patches: patch-lib_ext2fs_tdb.c
 > > 
 > > Log Message:
 > > Move #include <sys/types.h> before the #define of _XOPEN_SOURCE so that
 > > u_short etc. are being defined by it.
 > > 
 > > Fixes build on MirBSD. This is a leaf package.
 > 
 > This feels very wrong. _XOPEN_SOURCE and other macros should be defined
 > before any system headers are included, otherwise the result can be a
 > pretty horrible mess.

Yes, that sounds like a bad idea.

-- 
David A. Holland
dholland%netbsd.org@localhost