Re: CVS commit: pkgsrc/lang/ruby193-base

[David Holland <dholland-pkgchanges%netbsd.org@localhost>]

On Thu, May 10, 2012 at 08:04:10PM +0200, Hans Rosenfeld wrote:
 > >  > > > Modified Files:
 > >  > > >     pkgsrc/lang/ruby193-base: Makefile
 > >  > > > 
 > >  > > > Log Message:
 > >  > > > Prevent configure from using some random pkg-config tool found on 
 > > the
 > >  > > > system. Fixes build on SunOS 5.10.
 > >  > > I wonder which is better solution whether patching configure script or
 > >  > > adding pkg-config to USE_TOOLS.
 > >  > 
 > >  > When debugging this I tried adding pkg-config to USE_TOOLS, but that
 > >  > fails miserably and probably only on SunOS. The script calls pkg-config
 > >  > with PKG_CONFIG_DIRS=. set, which is removed by our pkg-config wrapper
 > >  > and replaced with the buildlinked pkg-config directories. This in turn
 > >  > causes the pkg-config call to fail as it can't find ruby.tmp.pc.
 > > 
 > > If it's using pkg-config, pkg-config should be in USE_TOOLS. I believe
 > > there's a way to fix this issue properly...
 > 
 > 
 > I don't. Feel free to prove me wrong.
 > 
 > Btw., pkg-config is only used when it is available, and only to verify
 > that the created .pc file is ok. It works very well without it.

In that case the Right Way(tm) to fix this is to just patch out the test...

-- 
David A. Holland
dholland%netbsd.org@localhost