Re: CVS commit: pkgsrc/games/gcompris

[David Holland <dholland-pkgchanges%netbsd.org@localhost>]

On Sun, Apr 08, 2012 at 09:07:06PM +0000, Thomas Klausner wrote:
 > Modified Files:
 >      pkgsrc/games/gcompris: Makefile PLIST distinfo
 > Added Files:
 >      pkgsrc/games/gcompris/patches:
 >          patch-src_chess__computer-activity_chess.c
 >          patch-src_chess__computer-activity_chess__notation.c
 > Removed Files:
 >      pkgsrc/games/gcompris/patches: patch-aa patch-ab patch-ac
 > 
 > Log Message:
 > Update to 12.01, provided by Mayuresh in wip.
 > Many many changes from last packaged version.

Including:

=> Checking for portability problems in extracted files
ERROR: [check-portability.awk] => Found test ... == ...:
ERROR: [check-portability.awk] configure: if test "x$USE_DEBUG" == "xyes" ; then

Explanation:
===========================================================================
The "test" command, as well as the "[" command, are not required to know
the "==" operator. Only a few implementations like bash and some
versions of ksh support it.

When you run "test foo == foo" on a platform that does not support the
"==" operator, the result will be "false" instead of "true". This can
lead to unexpected behavior.

There are two ways to fix this error message. If the file that contains
the "test ==" is needed for building the package, you should create a
patch for it, replacing the "==" operator with "=". If the file is not
needed, add its name to the CHECK_PORTABILITY_SKIP variable in the
package Makefile.
===========================================================================

*** Error code 1

:(

-- 
David A. Holland
dholland%netbsd.org@localhost