Re: CVS commit: pkgsrc/lang/squeak-vm

["OBATA Akio" <obache%netbsd.org@localhost>]

hi,

On Sun, 18 Dec 2011 00:50:11 +0900, John Marino <marino%netbsd.org@localhost> 
wrote:

> OBATA, I'm told DragonFly never had libossaudio in base, although the
> API is supported.
> What should the _OPSYS_HAS_OSSAUDIO setting be in this case?
> (edit: I'm told that it definitely refers to libossaudio so then it
> should be "no" I guess)

I guess that DragonFly supports OSS, but libossaudio is not required to use 
OSS, right?
If so, _OPSYS_HAS_OSSAUDIO should be set as "yes".

> The PLIST entry was unconditional, so that was an error.... right?

Yes, sure.

> I'm not understanding if you think think I handled this wrong or if you
> are pointing out the platform setting may be wrong (or both).

PLIST.oss=yes should be set if ${OSS_TYPE}!="none".

Probably, PLIST mismatch on DragonFly came from patch-ab:

+PLUGIN_REQUIRE_LIBRARY (ASOUND ossaudio)

It force to require libossaudio, then it should be changed.
But I'm not a cmake expert, so I don't know how to do it.
something like following...

IF (DEFINED LIBOSSAUDIO)
  PLUGIN_FIND_LIBRARY(ASOUND ${LIBOSSAUDIO})
ELSE
  DISABLE_MODULE()
ENDIF (DEFINED LIBOSSAUDIO)

--
OBATA Akio / obache%NetBSD.org@localhost