pkgsrc-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: pkgsrc/multimedia/vlc

On 11/12/2011 2:01 AM, Alistair Crooks wrote:
On Sat, Nov 12, 2011 at 01:40:55AM +0100, John Marino wrote:
On 11/12/2011 12:32 AM, Joerg Sonnenberger wrote:
Module Name:    pkgsrc
Committed By:   joerg
Date:           Fri Nov 11 23:32:39 UTC 2011

Modified Files:
        pkgsrc/multimedia/vlc: PLIST

Log Message:
Revert. No revbump, unconditional adding of files that are highly
platform specific, adding files that don't belong into a PLIST.

To generate a diff of this commit:
cvs rdiff -u -r1.45 -r1.46 pkgsrc/multimedia/vlc/PLIST

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

If the *.a and *.so are garbage, but *.la files aren't, why were the
*.la files removed as well?
pkgsrc creates the +CONTENTS file from the PLIST provided.  +CONTENTS
is the file which is installed with the binary package.  It is created
at package installation time on a per-platform basis.  So Mac OS X
gets a .dylib, AIX gets its own stuff, and the more usual ELF
platforms get .so, .a, .so.N and .so.N.M entries.  This is dependent
on the libtool-using package having a .la entry in the PLIST.

So please do NOT make changes based on the tinderbox "findings";
rather, I'd much prefer it if you set PKG_DEVELOPER=yes (which, as wiz
points out) does most of the work that tinderbox does, but for all
of the pkgsrc platforms as a whole.  It would also be great if you
would run your proposed changes past your mentors first so that we
don't end up with things like this happening.

I know it's daunting and difficult, and we all have to start out
somewhere - but we've been through a lot of these things in
pkgsrc-land, we're not quite as moronic as would first appear, and we
are here to help.

Please use that help :-)

Many thanks,
I have modified tinderbox to use PKG_DEVELOPER=yes. I've been using that, and I'll push that capability to pkgtools/tinderbox-dragonfly soon. It doesn't appear that tinderbox is directly reading the PLIST. It's just reporting a bunch of left over files after the package was installed and then removed. As this is the only package of about 300 that I've scanned that does this, I have to think that dumping files to destdir that aren't part of the package is indicative of a problem.

Home | Main Index | Thread Index | Old Index