pkgsrc-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: pkgsrc/games/xmris

On Sun, May 29, 2011 at 02:45:22AM +0000, David Holland wrote:
 > On Wed, May 25, 2011 at 01:27:01PM +0900, OBATA Akio wrote:
 >  >> I think you forgot USE_GAMESGROUP=yes...
 >  > 
 >  > I feel that USE_GAMESGROUP is user settable variable, not packages
 >  > because it is in mk/defaults/mk.conf.
 > No, it's there because of hysterical raisins and its association with
 > the old SETGIDGAME variable, which was itself (incorrectly) tagged as
 > user-settable. Please move it if you don't think it's in the right
 > place...
 > It is for packages to set to make sure that GAMES_USER and GAMES_GROUP
 > name a user and group that actually exist. Unfortunately there doesn't
 > seem to be any way to enforce that they can't be used if it isn't set.
 > (Maybe one of these days I'll add a feature to make for that...)

and yes, it would be good if pkglint could check this, but pkglint is
8500 lines of perl in one file and I have no idea where to put such a
check in.

David A. Holland

Home | Main Index | Thread Index | Old Index