Re: CVS commit: pkgsrc/databases/db4

["OBATA Akio" <obache%netbsd.org@localhost>]

On Sat, 12 Sep 2009 06:26:47 +0900, Thomas Klausner <wiz%netbsd.org@localhost> 
wrote:

> On Mon, Sep 07, 2009 at 06:37:12PM +0000, Matthias Drochner wrote:
> > Module Name:    pkgsrc
> > Committed By:   drochner
> > Date:           Mon Sep  7 18:37:12 UTC 2009
> >
> > Modified Files:
> >         pkgsrc/databases/db4: buildlink3.mk
> >
> > Log Message:
> > don't set BUILDLINK_LDADD/BUILDLINK_LIBS -- this ends up in the LIBS
> > environment variable which makes (at least if GNU configure is
> > used the common way) that everything in the pkg gets linked against db4,
> > whether needed or not, which causes hidden dependencies and strange errors
>
> This breaks mk/bdb.buildlink3.mk and thus e.g. p5-BerkeleyDB.
>
> The former does
> BDB_LIBS=       ${BUILDLINK_LDADD.${BDB_TYPE}}
> and the latter does
> MAKE_ENV+=      BERKELEYDB_NAME=${BDB_LIBS:Q}
> but ${BUILDLINK_LDADD.db4} wasn't defined any longer.
>
> So I reverted that part of the commit and it's now defined again.

How about siwtch to use other variable name, like BDB_LIBS.db4?
(and not only db4, but also db and db3, for DBD_DEFAULT != db4).

--
"Of course I love NetBSD":-)
OBATA Akio / obache%NetBSD.org@localhost