Re: CVS commit: pkgsrc/mail/sendmail

[jnemeth%victoria.tc.ca@localhost (John Nemeth)]

On Aug 21,  5:15pm, Emmanuel Dreyfus wrote:
}
} > As owner of the package, I have not approved this patch.  Having
} > had a chance to closely examine it, I would prefer it be done
} > slightly differently.  
} 
} How would you want it to be done? 

     I would prefer upstream did something, but you said you didn't
have any luck.  Failing that, I would prefer a feature test rather than
an FFR.  /usr/include/pwd.h uses

#if (_POSIX_C_SOURCE - 0) >= 199506L || (_XOPEN_SOURCE - 0) >= 500 || \
    defined(_REENTRANT) || defined(_NETBSD_SOURCE)

One of the _POSIX_C_SOURCE or _XOPEN_SOURCE (or both) might have worked
nicely.

     However, this was a relatively minor complaint.  The bigger issue
was the bad patch.  If it wasn't for that, I probably would have left
it.  But, when I saw that patch-ba patched multiple files, one of which
was already being patched, it was a goner.  I didn't have a lot of time
and just wanted to do some cleanup before the freeze.  I wasn't going
to spend time to cleanup bogus patches.  Produce clean patches that
follow pkgsrc guidelines and I'll probably take them.

}-- End of excerpt from Emmanuel Dreyfus