Re: CVS commit: [pkg_install-renovation] pkgsrc/pkgtools/pkg_install/files/lib

[Alistair Crooks <agc%pkgsrc.org@localhost>]

On Sun, Dec 28, 2008 at 08:13:56PM +0100, Joerg Sonnenberger wrote:
> On Sun, Dec 28, 2008 at 06:03:31PM +0000, Alistair Crooks wrote:
> > > I might be blind, but I can't find any 64bit arithmetic even in the
> > > NetBSD 1.4 version of the code. deweycmp is clearly using plain ints on
> > > those.
> > 
> > Yeah, it's a tad hard to find now, but:
> > 
> > http://cvsweb.netbsd.org/bsdweb.cgi/src/usr.sbin/pkg_install/lib/Attic/str.c?annotate=1.32&only_with_tag=MAIN
> > 
> > Lines 108 and 109 define the array of 64 bit integers used for the
> > individual components of the version number array.  Version 1.54 had
> > the same int64_t values. 1.55 was the split into dewey.[ch].
> 
> Right, that's why I didn't find it. The original Dewey code was only
> using integers. I don't really care either way.

No, the original Dewey code used 64-bit integers.  I know, because I
wrote it - the original motivation for using 64-bit integers was
because I was fed up with 32-bit integer representations as used
commonly as revision identifiers in bind zone files.  See all the code
in str.c version 1.32 if you doubt this.

Subsequent to its import into the tree, it was munged around, and made
to use native ints (by someone else), and I didn't notice that at the
time.

Anyway, enough of all this, and back to your favourite topics - the
end of the freeze is nigh!

Best,
Al