pkgsrc-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: pkgsrc/x11/tk

David Holland wrote:
On Wed, Aug 06, 2008 at 04:09:12AM +0000, David Sainty wrote:
 > Log Message:
 > Tk uses X event numbers to index an "event" array, as well as
 > adding a few of its own, starting with "VirtualEvent" (Which is
 > correctly set to LASTEvent, defined in include/X11/X.h).  In
 > xproto-7.0.13, a new event "GenericEvent" was added - making the
 > defined array broken for all of Tk's internal events.
> > The easy fix is to just add in the missing event into the hard-coded array. > > This patch was reported here:

Also here:

If you're satisfied that the concerns I raised there are addressed,
please close it. If not, it'll need a more elaborate solution of some

I'd say so. patch-ae should "do nothing" in the presence of older X.h. The main difference with the one that's committed to Tk head is that it will also continue to work the next time X.h grows a new event. patch-ae won't. But the HEAD fix is also 100 lines of patch over three files, and patch-ae is three lines over one file. I took the cheap road, because X doesn't ever (usually!) get new events.

But... If an xproto update breaks it again before we retire patch-ae with a Tk update then, ummm, I'll see if I can send you a New Zealand beer :)

Home | Main Index | Thread Index | Old Index