Subject: Re: CVS commit: pkgsrc/multimedia/dvd-slideshow
To: None <joerg@netbsd.org>
From: D'Arcy J.M. Cain <darcy@NetBSD.org>
List: pkgsrc-changes
Date: 12/29/2007 11:13:45
On Sat, 29 Dec 2007 15:47:27 +0000 (UTC)
Joerg Sonnenberger <joerg@netbsd.org> wrote:
> Fix up broken package imported during freeze:
> - fetch was broken, fixed
> - dependencies were not patterns, fixed
> - no conditional dependencies, this is not FreeBSD ports, thanks
> - when installing bash scripts, have a runtime dependency on it
> - patch scripts *before* installing them
> 
> In addition, add DESTDIR support.

Oops.  I found most of these issues later after I started using the
program and was going to deal with them after the freeze.  I also had
the following change to make.  I have also sent this as a suggested
portability change to the author.

SUBST_CLASSES+=         pipeline
SUBST_STAGE.pipeline=   post-build
SUBST_FILES.pipeline=   dvd-slideshow
SUBST_SED.pipeline=     -e 's/print0/printx/g;s/sort -z/sort/g;s/xargs
-0/xargs/g'
SUBST_MESSAGE.pipeline= Fixing Linux centric pipeline.

Shall I do this now anyway?

> Bump revision.

And bump it again?

There are still more issues.  It still doesn't build the DVD files
yet.  Something about the audio.  It's getting closer though and the
problem seems to be in some other package that this script uses.

-- 
D'Arcy J.M. Cain <darcy@NetBSD.org>
http://www.NetBSD.org/