Subject: Re: CVS commit: pkgsrc/mk/check
To: Joerg Sonnenberger <joerg@britannica.bec.de>
From: Roland Illig <rillig@NetBSD.org>
List: pkgsrc-changes
Date: 09/13/2007 18:11:20
Joerg Sonnenberger wrote:
> On Thu, Sep 13, 2007 at 09:52:46AM +0000, Roland Illig wrote:
> 
>>Log Message:
>>In bulk builds with a custom PKGSRCDIR, that directory should not appear
>>in binary packages. This check can be enabled by adding "pkgsrc" to
>>CHECK_WRKREF.
> 
> 
> I don't think it is a good idea. A number of tools are meant to operate
> on the pkgsrc tree and using the build environments PKGSRCDIR is IMO
> actually a sensible default value.

No. Assume that you are building packages for global distribution, but 
your PKGSRCDIR is /scratch/pkgsrc-current. The users of these packages 
won't usually have a directory like this, so a fixed value like 
/usr/pkgsrc is preferred, at least to me.

It would only make the documentation more complicated if we allowed the 
build-time PKGSRCDIR to pass through to the binary package.

For example, pkgtools/pkglint/Makefile has been doing this since 
November 2005 (revision 1.302).

Roland