Subject: Re: CVS commit: pkgsrc/net/Transmission
To: OBATA Akio <obache@netbsd.org>
From: Tobias Nygren <tnn@NetBSD.org>
List: pkgsrc-changes
Date: 08/11/2007 11:55:41
On Sat, 11 Aug 2007 18:28:52 +0900
"OBATA Akio" <obache@netbsd.org> wrote:

> On Sat, 11 Aug 2007 18:18:48 +0900, Tobias Nygren <tnn@netbsd.org> wrote:
> 
> >
> > Module Name:	pkgsrc
> > Committed By:	tnn
> > Date:		Sat Aug 11 09:18:48 UTC 2007
> >
> > Modified Files:
> > 	pkgsrc/net/Transmission: Makefile
> >
> > Log Message:
> > This package uses libevent, and the builtin version in netbsd-{2,3} is too
> > old. Use libevent from pkgsrc. Should fix PR pkg/36771 from Gilles Gravier.
> > PKGREVISION++
> >
> >
> > To generate a diff of this commit:
> > cvs rdiff -r1.5 -r1.6 pkgsrc/net/Transmission/Makefile
> >
> > Please note that diffs are not public domain; they are subject to the
> > copyright notices on the relevant files.
> 
> Why USE_BUILTIN.libevent=NO ?
> If devel/libevent/buitin.mk can't detect correct builtin version,
> it should be fixed.

I was under the impression that it doesn't work for builtin packages.
At least plenty of comments in other packages suggest that.
For example net/tor/Makefile:

BUILDLINK_API_DEPENDS.libevent+= libevent>=1.1a
# XXX the pkgsrc libevent builtin.mk does not detect the version of a builtin
# libevent, so we need to force use of the pkgsrc one
USE_BUILTIN.libevent=   no

If this is indeed wrong I agree it should be fixed, but in that case
it should be fixed for all packages using libevent.

-T