Subject: Re: CVS commit: pkgsrc/mk/flavor/pkg
To: None <pkgsrc-changes@NetBSD.org>
From: Juan RP <juan@xtrarom.org>
List: pkgsrc-changes
Date: 08/08/2007 19:16:27
On Wed, 08 Aug 2007 12:56:25 -0400
Greg Troxel <gdt@ir.bbn.com> wrote:

> "Johnny C. Lam" <jlam@netbsd.org> writes:
> 
> > Skip blank lines in +REQUIRED_BY files so that we don't error out
> > trying to locate the +CONTENTS file for a "blank" package.
> >
> > Why are there blank lines at all in +REQUIRED_BY?
> 
> This brings up the issue of what invariants we have for pkg metadata,
> and how they get checked.  It would be nice if pkg_admin had some
> check function (perhaps check-meta) that looked over all the files in
> /var/db/pkg and checked each to make sure it is ok, both syntactically
> and semantically (I seem to end up with lines in +REQUIRED_BY for
> packages that aren't installed, and in particular I think at least in
> the past "pkg_delete foo/" would provoke this).
> 
> It's certainly a good thing to be robust when it's easy, but having
> hhe equivalent of pkg_lint for the pkg db directory would be nice.

IMHO, we'd have to find and fix the code that is adding blank lines in
these files. I believe that pkg_admin is the tool that should fix these
errors in the db.

-- 
Juan Romero Pardines 	- The NetBSD Project
http://plog.xtrarom.org 	- NetBSD/pkgsrc news in Spanish