Subject: Re: CVS commit: pkgsrc/graphics/png
To: Todd Vierling <tv@netbsd.org>
From: Roland Illig <rillig@NetBSD.org>
List: pkgsrc-changes
Date: 01/03/2007 21:40:01
Todd Vierling wrote:
> On 1/3/07, Bernd Ernesti <netbsd@lists.veego.de> wrote:
> 
>> This breaks a pkg_chk -n -u -g:
>>
>> make: 
>> "../../x11/gnome-libs/../../graphics/imlib/../../graphics/netpbm/../../graphics/png/../../x11/gnome-libs/../../graphics/imlib/../../graphics/netpbm/../../graphics/png/buildlink3.mk" 
>> line 16: Malformed conditional (${OPSYS} == "Interix")
> 
> 
> Blargh.  Old bmake syntax strikes again (I think).  I'll fix that.
> 
>> And pkglint has also some warnings:
>>
>> WARN: buildlink3.mk:18: Definition of BUILDLINK_API_DEPENDS is missing.
>> WARN: buildlink3.mk:20: Expected BUILDLINK_DEPTH:= 
>> ${BUILDLINK_DEPTH:S/+$//}.
> 
> 
> Hm.  I'll have to figure out how to work around that one, and will
> look for similar instances and how they handled the situation.

The trick here is to run pkglint -Wall:

NOTE: buildlink3.mk:17: This directive should be indented by 2 spaces.
NOTE: buildlink3.mk:19: This directive should be indented by 2 spaces.

When these notes are fixed, the warning disappears, too. pkglint assumes 
that the if...endif pairs are properly indented, and that after the 
first one starting at the left margin, there will only be .include lines.

Roland