Subject: Re: CVS commit: pkgsrc/graphics/png
To: Todd Vierling <tv@NetBSD.org>
From: Bernd Ernesti <netbsd@lists.veego.de>
List: pkgsrc-changes
Date: 01/03/2007 20:31:38
On Wed, Jan 03, 2007 at 04:23:10PM +0000, Todd Vierling wrote:
> 
> Module Name:	pkgsrc
> Committed By:	tv
> Date:		Wed Jan  3 16:23:10 UTC 2007
> 
> Modified Files:
> 	pkgsrc/graphics/png: Makefile buildlink3.mk distinfo
> Added Files:
> 	pkgsrc/graphics/png/patches: patch-ac
> 
> Log Message:
> Don't allow "ld --version-script" on Interix.  Fixes PR pkg/35210.
> Based on patch idea from Aleksey Cheusov <cheusov@tut.by>.
> (Sanity tested for breakage on a non-Interix platform, NetBSD.)

This breaks a pkg_chk -n -u -g:

make: "../../x11/gnome-libs/../../graphics/imlib/../../graphics/netpbm/../../graphics/png/../../x11/gnome-libs/../../graphics/imlib/../../graphics/netpbm/../../graphics/png/buildlink3.mk" line 16: Malformed conditional (${OPSYS} == "Interix")
make: "../../x11/gnome-libs/../../graphics/imlib/../../graphics/netpbm/../../graphics/png/../../x11/gnome-libs/../../graphics/imlib/../../graphics/netpbm/../../graphics/png/buildlink3.mk" line 16: Need an operator
make: Fatal errors encountered -- cannot continue
eval: 1: Syntax error: "(" unexpected

And pkglint has also some warnings:

WARN: buildlink3.mk:18: Definition of BUILDLINK_API_DEPENDS is missing.
WARN: buildlink3.mk:20: Expected BUILDLINK_DEPTH:= ${BUILDLINK_DEPTH:S/+$//}.

Bernd