Subject: Re: CVS commit: pkgsrc/pkgtools/pkg_chk
To: None <tron@netbsd.org, jmmv@NetBSD.org>
From: None <david.sainty@dtsp.co.nz>
List: pkgsrc-changes
Date: 11/07/2006 19:29:03
Matthias Scheler writes:

> Module Name:	pkgsrc
> Committed By:	tron
> Date:		Sun Nov  5 21:53:27 UTC 2006
> 
> Modified Files:
> 	pkgsrc/pkgtools/pkg_chk: Makefile
> 	pkgsrc/pkgtools/pkg_chk/files: pkg_chk.sh
> 
> Log Message:
> Update "pkg_chk" package to version 1.83:
> Do *not* use "TMPDIR" variable. If the user has already set an environment
> variable "TMPDIR" it well be overwritten my the path to the directory
> created by the script and passed to "make". As a result it will get
> compiled into certain packages (e.g. "sysutils/dbus") which will no
> longer work after the directory has been removed.

I think that counts as a bug in "sysutils/dbus".  Avoiding the problem
in "pkg_chk" is also a good idea, but assuming that the build user's
idea of what constitutes a good TMPDIR will suit everyone is a little
dangerous.

For example, a user might set TMPDIR="$HOME/tmp" because they don't
want to trust the safety of temporary file management of miscellaneous
applications in a public /tmp.  If "sysutils/dbus" compiles that in,
it will no doubt limit the number of users that can make use of that
package.

Cheers,

Dave