Subject: Re: CVS commit: pkgsrc/net/samba
To: Roland Illig <rillig@netbsd.org>
From: Todd Vierling <tv@netbsd.org>
List: pkgsrc-changes
Date: 10/17/2006 15:24:25
[moved additionals to Bcc:]

On 10/17/06, Roland Illig <rillig@netbsd.org> wrote:
> > Rewrite to use a shell loop.
>
> I'm sorry that I broke the samba package. I had tested the change, but
> it seems I only did that while the distfiles were extracted.

bmake's .for is a little counterintuitive in the context of make
variables, which are traditionally expanded at shell reference time or
!= time.  Internally, .for is expanded by parsing the loop multiple
times.  The effect is that .for does an internal != type of assignment
to the variable for each iteration over the loop.

No problem on the fix; it came up when pkg_chk was doing its daily
scan of packages on one of my boxes.  8-)

-- 
-- Todd Vierling <tv@duh.org> <tv@pobox.com> <todd@vierling.name>