Subject: CVS commit: pkgsrc/mk/fetch
To: None <pkgsrc-changes@NetBSD.org>
From: Roland Illig <rillig@netbsd.org>
List: pkgsrc-changes
Date: 10/07/2006 12:22:06
Module Name:	pkgsrc
Committed By:	rillig
Date:		Sat Oct  7 12:22:06 UTC 2006

Modified Files:
	pkgsrc/mk/fetch: fetch.mk

Log Message:
Meta-packages that had DIST_SUBDIR set (for whatever reason) tried to
fetch files with an empty name, for example "geda/".

The problem was that the expression ${LIST:S,^,${DIST_SUBDIR}/,} results
in ${DIST_SUBDIR}/ when ${LIST} is empty. This is surprising but matches
the documentation in the manual page, so this cannot be called a bug.

The proper fix is to use ${LIST:@f@${DIST_SUBDIR}/${f}@} instead.

Noticed by Don Woodstock on #netbsd-code.


To generate a diff of this commit:
cvs rdiff -r1.20 -r1.21 pkgsrc/mk/fetch/fetch.mk

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.