Subject: Re: CVS commit: pkgsrc
To: Alistair Crooks <agc@pkgsrc.org>
From: Johnny Lam <jlam@pkgsrc.org>
List: pkgsrc-changes
Date: 07/20/2006 11:04:55
Alistair Crooks wrote:
> On Thu, Jul 20, 2006 at 01:48:15PM +0000, Johnny C. Lam wrote:
>> Module Name:	pkgsrc
>> Committed By:	jlam
>> Date:		Thu Jul 20 13:48:15 UTC 2006
>>
>> Modified Files:
>> 	pkgsrc/security/amavisd-new: Makefile
>> 	pkgsrc/textproc/ruby-nqxml: Makefile
>> 	pkgsrc/textproc/ruby-xmlscan: Makefile
>>
>> Log Message:
>> REPLACE_INTERPRETER occurs as part of the configure step, so don't set
>> NO_CONFIGURE.
> 
> Perhaps, to be on the safe side, we should check whether
> REPLACE_INTERPRETER is set, as well as the value/setting of
> NO_CONFIGURE?
> 
> The more drastic step is to say
> 
> .if defined(REPLACE_INTERPRETER)
> .undef NO_CONFIGURE
> .endif
> 
> I think we should err on the side of POLA - there may well be people
> out there with custom package Makefiles not under our control.

I was going to check with rillig on this before I re-added the checks. 
There are many variables that require the configure step to occur, and I 
need some time to go through and make a list, and I wanted to coordinate 
with any changes rillig might want to make to pkglint.  I just wanted to 
get these packages building properly again.

	Cheers,

	-- Johnny Lam <jlam@pkgsrc.org>