Subject: Re: CVS commit: pkgsrc/mk
To: Roland Illig <>
From: Johnny C. Lam <>
List: pkgsrc-changes
Date: 06/10/2006 18:03:55
Roland Illig wrote:
> Johnny C. Lam wrote:
>> Module Name:    pkgsrc
>> Committed By:    jlam
>> Date:        Fri Jun  9 13:59:08 UTC 2006
>> Modified Files:
>>     pkgsrc/mk:
>>     pkgsrc/mk/check:
>>     pkgsrc/mk/depends:
>>     pkgsrc/mk/extract:
>>     pkgsrc/mk/flavor/pkg:
>>     pkgsrc/mk/install:
>>     pkgsrc/mk/package:
>>     pkgsrc/mk/patch:
>>     pkgsrc/mk/tools:
>> Added Files:
>>     pkgsrc/mk:
>> Log Message:
>> Introduce the capability to gather all the warnings and errors that
>> are generated for a target and output them all at once at the conclusion
>> of the target's invocation.  The implementation is in,
>> which defines a macro target "error-check" that will print out any
>> non-empty warning and error files in ${WARNING_DIR} and ${ERROR_DIR}
>> and exit appropriately if there were errors.
> Now the code looks pretty weird, at least in 
> mk/check/ The command ${WARNING_MSG} is still used, 
> but instead of ${ERROR_MSG}, you are using a simple ${ECHO}, which in my 
> opinion doesn't express clearly enough what the code wants to say.

The code will now print out missing interpreters in all files instead of 
stopping at the first one.  I didn't think it was necessary to modify 
the WARNING_MSG ones to print to a file in ${WARNING_DIR}, though it 
could easily have been done.


	-- Johnny Lam <>