Subject: CVS commit: pkgsrc/mk/buildlink3
To: None <pkgsrc-changes@NetBSD.org>
From: Roland Illig <firstname.lastname@example.org>
Date: 06/09/2006 06:02:33
Module Name: pkgsrc
Committed By: rillig
Date: Fri Jun 9 06:02:33 UTC 2006
pkglint says, the :Q operator should not be used in double quotes.
The code here only worked due to many conincidences: Let's assume a
variable has the value "a b" and is used with the :Q operator, which
results in "a\ b" (a, backslash, space, b). When used in double quotes,
the shell command looks like:
echo "a\ b"
which, depending on the shell, may output the backslash literally or
not. In the case of this file, the ":Q" string was not passed to
echo(1), but to sed(1). sed(1) in turn interprets (backslash, space) in
the replacement text as equivalent to (space), and that's where the
backslash finally disappears. So it's only to this coincident that the
code worked although it was not correct.
To generate a diff of this commit:
cvs rdiff -r1.178 -r1.179 pkgsrc/mk/buildlink3/bsd.buildlink3.mk
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.