Subject: CVS commit: pkgsrc/pkgtools/pkglint/files
To: None <pkgsrc-changes@NetBSD.org>
From: Roland Illig <rillig@netbsd.org>
List: pkgsrc-changes
Date: 05/31/2006 08:46:01
Module Name:	pkgsrc
Committed By:	rillig
Date:		Wed May 31 08:46:00 UTC 2006

Modified Files:
	pkgsrc/pkgtools/pkglint/files: makevars.map pkglint.pl

Log Message:
Added a check for variables that are evaluated at load time. Especially
for lists of something, this can lead to unexpected behavior. Currently,
only the variables BUILDLINK_DEPENDS, BUILDLINK_PACKAGES and PKG_OPTIONS
may be looked at during load time.

This warning reveals the bad practice to "patch" CONFIGURE_ARGS at load
time, for example:

> CONFIGURE_ARGS:=      ${CONFIGURE_ARGS:S/--disable-esd/--enable-esd/}
WARN: audio/bmp-esound/Makefile:14: CONFIGURE_ARGS should not be
      evaluated at load time.


To generate a diff of this commit:
cvs rdiff -r1.97 -r1.98 pkgsrc/pkgtools/pkglint/files/makevars.map
cvs rdiff -r1.593 -r1.594 pkgsrc/pkgtools/pkglint/files/pkglint.pl

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.