Subject: CVS commit: pkgsrc/x11/Xaw3d
To: None <pkgsrc-changes@NetBSD.org>
From: Mark Davies <markd@netbsd.org>
List: pkgsrc-changes
Date: 03/13/2006 00:16:23
Module Name:	pkgsrc
Committed By:	markd
Date:		Mon Mar 13 00:16:23 UTC 2006

Modified Files:
	pkgsrc/x11/Xaw3d: Makefile distinfo
Added Files:
	pkgsrc/x11/Xaw3d/patches: patch-ac

Log Message:
The x11/Xaw3d library has an integer overflow error in the computation
of the geometry for a Box Layout (file Box.c).  There, the box tries
to extend its width until its height fits within the constraint height
(influenced by the window manager).  Unfortunately, widths are 16bit
unsigned and in the error case (occuring under KDE), the constraint
width is 65535, i.e. maximal.
The code loops until either the computed height is smaller than the
constraint height or the width exceeds the constraint width.  In each
loop iteration, the width of the box layout is doubled.  This loop
does not terminate, if one chooses unfortunate initial width, as the
width wraps around if it overflows 16 bits and if the maximal
constraint width is SHORT_INT_MAX.
Patch tries to capture the overflow before it wraps around the
`width' variable, setting the width to the maximal one.

From Stephan Thesing in PR pkg/32445. Bump PKGREVISION.


To generate a diff of this commit:
cvs rdiff -r1.47 -r1.48 pkgsrc/x11/Xaw3d/Makefile
cvs rdiff -r1.8 -r1.9 pkgsrc/x11/Xaw3d/distinfo
cvs rdiff -r0 -r1.1 pkgsrc/x11/Xaw3d/patches/patch-ac

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.