Subject: Re: CVS commit: pkgsrc/chat/ymessenger
To: Todd Whitesel <toddpw@toddpw.org>
From: Julio M. Merino Vidal <jmmv84@gmail.com>
List: pkgsrc-changes
Date: 03/12/2006 12:11:55
On Sunday 12 March 2006 06:49, Todd Whitesel wrote:
> > I think that what Jeremy meant was that you ought to use the subst
> > framework rather than calling sed directly.  Grep for SUBST_CLASSES in
> > the existing packages; those will serve you as examples.
> >
> > Also, creating a file from the installation stage is somewhat
> > "incorrect". You should run sed in the 'do-build' target, create the file
> > in the work directory and only then, during installation, install it. 
> > This way build problems are separated from install ones.
>
> How does this interact with rpm2pkg ?  The original chat/ymessenger used it
> in the install phase; the file I need to sed doesn't appear under the work
> directory after either 'make' or 'make install'.
>
> Should the existing package have used rpm2pkg differently?

Oh, sorry.  I have no clue on how Linux packages work.  I was pointing that
out because I didn't see your package was using rpm2pkg.

Cheers,

-- 
Julio M. Merino Vidal <jmmv84@gmail.com>
The Julipedia - http://julipedia.blogspot.com/