On Wednesday 08 March 2006 05:44, you wrote:
> On Tue, Mar 07, 2006 at 08:08:28AM -0800, Jeremy C. Reed wrote:
> > > The commit simply repeats what was in the PR. Sorry if that was
> > > confusing.
> > >
> > > Sorry this is my first commit in a long time and also my first in
> > > pkgsrc... where is the format of the commit message documented again?
> > > (I don't recall seeing anything in the pkgsrc developer's guide, which
> > > I did just read)
> >
> > http://www.netbsd.org/developers/commit-guidelines.html
> > numbers nine and ten
>
> ah okay... it is possible to retroactively fix this one?
>
> > Here is an example:
> >
> >    Updated to version 1.0.4.
> >
> >    Now also depend on suse_gdk-pixbuf.
> >
> >    Use sed to create ymessenger script instead of using symlink.
> >
> >    This closes PR 18416 from Andy Ruhl.
> >
> > (Probably using "sed" is not right, but that is a different topic for
> > pkgsrc-users.)
>
> Not unless you know a better way to force Linux emulation to be used when
> that shell script exec's ymessenger.bin after setting up LD_LIBRARY_PATH.

I think that what Jeremy meant was that you ought to use the subst
framework rather than calling sed directly.  Grep for SUBST_CLASSES in
the existing packages; those will serve you as examples.

Also, creating a file from the installation stage is somewhat "incorrect".
You should run sed in the 'do-build' target, create the file in the work
directory and only then, during installation, install it.  This way build
problems are separated from install ones.

-- 
Julio M. Merino Vidal <jmmv84@gmail.com>
The Julipedia - http://julipedia.blogspot.com/