Subject: Re: CVS commit: pkgsrc/pkgtools/pkglint
To: None <pkgsrc-changes@NetBSD.org>
From: Roland Illig <rillig@NetBSD.org>
List: pkgsrc-changes
Date: 02/25/2006 18:34:59
joerg@britannica.bec.de wrote:
> On Sat, Feb 25, 2006 at 04:58:55PM +0100, Roland Illig wrote:
> 
>>I was pretty sure, and someone else has complained, too. Well, the 
>>quotes are not needed, but without them, the '|' characters obviously 
>>have to be escaped properly so the shell does not interpret them as pipe 
>>operators.
> 
> 
> I'm normally using "," as separator, maybe we can adopt a common style
> over pkgsrc? It would make a possible sed-quotation target in bmake
> simpler as well.

An ad-hoc statistic shows:

    13 :
    16 /
    22 !
   350 |
   491 ,

As "," is not among the shell special characters, I'd prefer this one. 
Of course we will get problems when the replacement text contains a "," 
itself, as in -Wl,-R/foodir or certain pathnames on Solaris.

Should we fall back to "|" (or something else) in these cases or should 
we use the :C/,/\\,/g operator?

Roland