Subject: Re: CVS commit: pkgsrc/pkgtools/pkglint
To: Adam <adam@albedo.art.pl>
From: Roland Illig <rillig@NetBSD.org>
List: pkgsrc-changes
Date: 02/25/2006 16:58:55
Adam wrote:
>>> Module Name:    pkgsrc
>>> Committed By:    adam
>>> Date:        Sat Feb 25 09:45:38 UTC 2006
>>> Modified Files:
>>>     pkgsrc/pkgtools/pkglint: Makefile
>>> Log Message:
>>> Added sed quotes
>>
>>
>> Your version of pkglint is outdated. The current version does not  
>> require quotes in sed(1) expressions. It even discourages them.
>>
>> The reason is that the variables need a :Q operator to be correctly  
>> quoted for the shell. Adding additional 'quotes' or "quotes" makes  
>> the quoting incorrect.
>>
>> Please revert that change.
> 
> 
> Dear Roland,
> 
> Are you sure the quotes are not needed?
> Without quotes, I have (today's pkgsrc):

I was pretty sure, and someone else has complained, too. Well, the 
quotes are not needed, but without them, the '|' characters obviously 
have to be escaped properly so the shell does not interpret them as pipe 
operators.

I will investigate how pkglint can check this automatically.

Thanks again,

Roland