Subject: Re: CVS commit: pkgsrc/pkgtools/pkglint
To: Roland Illig <rillig@NetBSD.org>
From: Adam <adam@albedo.art.pl>
List: pkgsrc-changes
Date: 02/25/2006 16:15:18
>> Module Name:	pkgsrc
>> Committed By:	adam
>> Date:		Sat Feb 25 09:45:38 UTC 2006
>> Modified Files:
>> 	pkgsrc/pkgtools/pkglint: Makefile
>> Log Message:
>> Added sed quotes
>
> Your version of pkglint is outdated. The current version does not  
> require quotes in sed(1) expressions. It even discourages them.
>
> The reason is that the variables need a :Q operator to be correctly  
> quoted for the shell. Adding additional 'quotes' or "quotes" makes  
> the quoting incorrect.
>
> Please revert that change.

Dear Roland,

Are you sure the quotes are not needed?
Without quotes, I have (today's pkgsrc):

===> *** No /usr/distfiles/pkg-vulnerabilities file found,
===> *** skipping vulnerability checks. To fix, install
===> *** the pkgsrc/security/audit-packages package and run
===> *** '/usr/pkg/sbin/download-vulnerability-list'.
===> Extracting for pkglint-4.57
===> Required installed package digest>=20010101: digest-20050731 found
===> Required installed package p5-Digest-SHA1-[0-9]*: p5-Digest- 
SHA1-2.11 found
===> Required installed package perl>=5.0: perl-5.8.7nb8 found
cd /usr/pkgsrc/pkgtools/pkglint/files && /bin/cp lintpkgsrc.0  
lintpkgsrc.1 lintpkgsrc.pl pkglint.0 pkglint.1 pkglint.pl plist- 
clash.pl /usr/pkgsrc/pkgtools/pkglint/work
===> Patching for pkglint-4.57
===> Overriding tools for pkglint-4.57
===> Configuring for pkglint-4.57
@PKGSRCDIR@: not found
/usr/pkgsrc: permission denied
g: not found
@PREFIX@: not found
/usr/pkg: permission denied
g: not found
@DISTVER@: not found
4.57: not found
g: not found
@MAKE@: not found
make: no target to make.
g: not found
@PERL@: not found
g: not found
@DATADIR@: not found
/usr/pkg/share/pkglint: not found
g: not found
sed: 1: "s": substitute pattern can not be delimited by newline or  
backslash
sed: 1: "s": substitute pattern can not be delimited by newline or  
backslash
@PKGSRCDIR@: not found
/usr/pkgsrc: permission denied
g: not found
@PREFIX@: not found
/usr/pkg: permission denied
g: not found
@DISTVER@: not found
4.57: not found
g: not found
@MAKE@: not found
make: no target to make.
g: not found
@PERL@: not found
g: not found
@DATADIR@: not found
/usr/pkg/share/pkglint: not found
g: not found
sed: 1: "s": substitute pattern can not be delimited by newline or  
backslash
@PKGSRCDIR@: not found
/usr/pkgsrc: permission denied
g: not found
@PREFIX@: not found
/usr/pkg: permission denied
g: not found
@DISTVER@: not found
4.57: not found
g: not found
@MAKE@: not found
make: no target to make.
g: not found
@PERL@: not found
g: not found
@DATADIR@: not found
/usr/pkg/share/pkglint: not found
g: not found
chmod: ./lintpkgsrc.pl: No such file or directory
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/pkgtools/pkglint
===>
===> There was an error during the ``configure'' phase.
===> Please investigate the following for more information:
===>      * log of the build
===>      * /dev/null
===>
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/pkgtools/pkglint



Kind regards,
Adam