Subject: Re: CVS commit: pkgsrc/multimedia/mjpegtools
To: None <ghen@netbsd.org>
From: Julio M. Merino Vidal <jmmv84@gmail.com>
List: pkgsrc-changes
Date: 12/13/2005 14:07:36
On 12/13/05, Geert Hendrickx <ghen@netbsd.org> wrote:
>
> Module Name:    pkgsrc
> Committed By:   ghen
> Date:           Tue Dec 13 12:19:37 UTC 2005
>
> Modified Files:
>         pkgsrc/multimedia/mjpegtools: Makefile
>
> Log Message:
> Patch some shell scripts to start with #!${PREFIX}/bin/bash instead of #!=
/bin/bash (at least two of these scripts don't run with /bin/sh).  This sol=
ves part of PR pkg/29342 (the other part concerns geography/gpsdrive).

You should use the EVAL_PREFIX trick rather than assuming bash lives
in ${PREFIX}; this way pkgsrc fetches the correct prefix from the installed
package.  Otherwise, this breaks in the pkgviews world.  As an example
see pkgtools/autoswc/Makefile (or any of the other packages using this
stuff).

Also, please specify in the commit messages who approved your (first)
changes.

Thanks!

--
Julio M. Merino Vidal <jmmv84@gmail.com>
The Julipedia - http://julipedia.blogspot.com/
The NetBSD Project - http://www.NetBSD.org/