Subject: Re: CVS commit: pkgsrc/lang/python24
To: None <>
From: Roland Illig <>
List: pkgsrc-changes
Date: 12/09/2005 09:49:25
Roland Illig wrote:
> Roland Illig wrote:
>> Marc Recht wrote:
>>> Module Name:    pkgsrc
>>> Committed By:    recht
>>> Date:        Fri Dec  9 07:12:28 UTC 2005
>>> Modified Files:
>>>     pkgsrc/lang/python24: Makefile
>>> Log Message:
>>> Remove the :Q from vars that go into PLIST_SUBST, since it breaks
>>> the PLIST generation.
>> There had been some other variables that broke the PLIST generation. 
>> The two you changed were ok.
>> PY_PLATNAME and PY_VER_SUFFIX are not pre-quoted, in contrast to 
>> EXTRA_SO_SUBST, so they would need the :Q operator if there was a 
>> chance for special characters in them. Currently there is no need, but 
>> to achieve uniformity in pkgsrc I ask you to revert that change.
> Oops. That was completely wrong. Sorry.

No, it wasn't. I had looked in the wrong lines when checking. There are 
many quoted instances of "Darwin", "SunOS", and others, but everything 
that is assigned to PY_PLATNAME is ${LOWER_OPSYS} and some other 
variables, all unquoted. So the quoting is needed.