Subject: CVS commit: pkgsrc/mk/bulk
To: None <>
From: Roland Illig <>
List: pkgsrc-changes
Date: 11/18/2005 10:18:05
Module Name:	pkgsrc
Committed By:	rillig
Date:		Fri Nov 18 10:18:05 UTC 2005

Modified Files:
	pkgsrc/mk/bulk: post-build

Log Message:
Code cleanup, bugfixes and separation of PKGSRCDIR and BULKFILESDIR.

- Added section headings to make reading the code more efficient.
- Added bp_die() for uniform error messages.
- Added sanity checks:
  - $BULK_BUILD_CONF must be a regular file.
  - Protect against spurious output from the bulk.conf file.
  - Check that configuration variables are defined, non-empty and
    do not contain newlines.
  - Properly extract MAKECONF from the bulk.conf file when getting the
    mk.conf variables.
  - Protect against spurious output from BMAKE show-vars.
- Fixed the use of undefined values ($startdate).
- Changed some calls to my_system() to a more secure form.
- Check if the calls to chdir() actually work.
- Look for the BROKENFILEs in BULKFILESDIR instead of USR_PKGSRC.
- Changed postfix conditions to prefix conditions. Example:
  do_foo() if $bar; ==> if ($bar) { do_foo(); }

To generate a diff of this commit:
cvs rdiff -r1.58 -r1.59 pkgsrc/mk/bulk/post-build

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.