Subject: Re: CVS commit: pkgsrc/pkgtools/pkglint/files
To: Alistair Crooks <>
From: Roland Illig <>
List: pkgsrc-changes
Date: 11/10/2005 09:38:14
Alistair Crooks wrote:
> On Thu, Nov 10, 2005 at 07:46:24AM +0000, Roland Illig wrote:
>>Module Name:	pkgsrc
>>Committed By:	rillig
>>Date:		Thu Nov 10 07:46:24 UTC 2005
>>Modified Files:
>>	pkgsrc/pkgtools/pkglint/files:
>>Log Message:
>>Added (currently disabled) code to scan for variable names in
>>pkgsrc/mk/defaults/mk.conf. All those variable names are then checked as
>>being of type Userdefined. As that file is currently too unstructured
>>and contains too much garbage, this check cannot yet be enabled.
> There is no garbage in pkgsrc/mk/defaults/mk.conf - you must be thinking
> of something else.

Roland Illig wrote:
Because of the similarity of the filename, I have always assumed that 
all variables in mk/defaults/mk.conf are default values for things that 
can be set by the pkgsrc user in mk.conf. But this is wrong. This file 
has become a placeholder for all kinds of variables, lacking proper 
comments explaining what each variable is meant for.

That's what I mean. In mk.conf, there's just a listing of variables. 
Many of them lack the information about whether they are intended to be 
set by the user or a package.

As there had been confusion in the not-so-far past about similar 
variables like PKGREVISION (which should only be set in a package's 
Makefile, not in any other file), PKGBASE and PKGNAME, I want to 
separate the default definitions of user-settable variables from the 
package-settable ones. That's all it is about.