Subject: Re: CVS commit: pkgsrc/devel/bmake
To: Jeremy C. Reed <firstname.lastname@example.org>
From: Todd Vierling <email@example.com>
Date: 11/02/2005 13:51:28
On Wed, 2 Nov 2005, Jeremy C. Reed wrote:
> > pkgsrc/devel/bmake/files: job.c
> > Log Message:
> > Fix glaring error in job.c that I fixed back in the prehistoric
> > bootstrap-pkgsrc incarnation (WTERMSIG->WSTOPSIG).
> Please send the fix to the MAINTAINER too for his tarball. And also
> commit to src/usr.bin/make too.
The problem has not been in src/usr.bin/make ever, as far as I can tell. I
don't know how it got into these sources in the first place. It was
comparison against src/usr.bin/make that helped me find the problem back
when bootstrap-pkgsrc was outside of the pkgsrc tree.
Interix bails out on the build because the job.c conditional
WIFSTOPPED(x) && (WTERMSIG(x) == SIGCONT)
is invalid there, and rightly so. The right hand expression is supposed to
be WSTOPSIG(x) == SIGCONT.
-- Todd Vierling <firstname.lastname@example.org> <email@example.com> <firstname.lastname@example.org>