Subject: Re: CVS commit: pkgsrc/benchmarks/bytebench
To: Todd Vierling <firstname.lastname@example.org>
From: Urban Boquist <email@example.com>
Date: 11/01/2005 22:49:55
>>>>> Todd Vierling writes:
Todd> Modified Files:
Todd> pkgsrc/benchmarks/bytebench: Makefile distinfo
Todd> Added Files:
Todd> pkgsrc/benchmarks/bytebench/patches: patch-ag
Todd> Log Message:
Todd> 4.1.0nb1: Interix has no sync(2). Use fsync(2) there instead.
Todd> While there, use fsync(2) on all hosts. Without this, the
Todd> fstime benchmark will be disproportionately biased toward OS's
Todd> and hardware that buffer larger amounts of data in memory before
Todd> [background] syncing.
the second part of this change seems inappropriate, IMHO. The
benchmark may be biased, but that is not up to pkgsrc to
decide. Pkgsrc is just supposed to be a way to port software, it
should not change the behavior of an old and well defined benchmark.