Subject: Re: CVS commit: pkgsrc/pkgtools/pkglint/files
To: Roland Illig <email@example.com>
From: Hubert Feyrer <firstname.lastname@example.org>
Date: 09/04/2005 02:15:52
On Sat, 3 Sep 2005, Roland Illig wrote:
> Modified Files:
> pkgsrc/pkgtools/pkglint/files: pkglint.pl
> Log Message:
> When RCS Ids are detected in patches, don't suggest the -ko mode, but
> ask the user to remove the offending line from the patch.
Maybe give a bit more guidance here - RCS IDs can usually be pushed out of
patches by narrowing down the number of content lines to 2, 1 or even 0.
To do so, pkgdiff can be done (which checks if there's a RCS ID and
reduces context automatically), or find the right switch to diff(!).
Maybe something like:
$line->log_warning("Possible RCS tag \"\$$1\$\". Please remove it by reducing the number of context lines with pkgdiff or \"diff -uU\".");