Subject: Re: CVS commit: pkgsrc/graphics/imlib2
To: Dieter Baron <>
From: Johnny C. Lam <>
List: pkgsrc-changes
Date: 06/11/2005 02:02:28
On Sat, Jun 11, 2005 at 01:55:59AM +0200, Dieter Baron wrote:
> In article <> Johnny wrote:
> : > I think that the best way to achieve this is to only add mmx to
> : > PKG_SUPPORTED_OPTIONS when on i386.  This way you can handle the
> : > PKG_OPTIONS:Mmmx unconditionally.  (FWIW, this is what I did in
> : > mplayer during the switch and proved to be very useful.)
> : FWIW, I agree with Julio as PKG_SUPPORTED_OPTIONS is naturally expected 
> : to contain options that are truly supported.  I think it's okay for the 
> : same package on different platforms to support different options.
>   If we want to go that route, should handle the case
> where there are no supported options.  With the applied patch, if
> there are no supported options, PKG_OPTIONS is set to empty and the
> rest of the file is skipped.  This makes it seem to the user that the
> package does not use the options framework, while no special treatment
> is needed in the package Makefile or  What do you think?

This seems very sensible to me.  Please go ahead and commit this.


	-- Johnny Lam <>