Subject: Re: CVS commit: pkgsrc/mail/fetchmail
To: None <frueauf@netbsd.org, dillo@danbala.tuwien.ac.at>
From: Jukka Salmi <j+nbsd@2005.salmi.ch>
List: pkgsrc-changes
Date: 05/30/2005 19:05:44
--96YOpH+ONegL0A3E
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi,

first of all sorry for the confusion, seems I was too hasty when I sent
the initial patch...

> > Ok, since we know that gssapi needs kerberos V (e.g. does not work with
> > kerberos IV), how about the following change:

Even though GSSAPI in fetchmail needs Kerberos V, building with Kerberos IV
support in addition to these two options works fine (I can't test if krb4
really works, but it builds fine and krb5 and gssapi do work). So I don't
see a reason to disallow option `kerberos4' if `gssapi' is enabled.

My proposal (patch agains options.mk as it is now) is attached.


Regards, Jukka

-- 
bashian roulette:
$ ((RANDOM%6)) || rm -rf ~

--96YOpH+ONegL0A3E
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="options.mk.patch"

--- options.mk.orig	2005-05-30 18:18:51.000000000 +0200
+++ options.mk	2005-05-30 18:56:43.000000000 +0200
@@ -17,8 +17,7 @@
 ###
 ### Authentication via GSSAPI (currently only over Kerberos V) support.
 ###
-.if !empty(PKG_OPTIONS:Mgssapi) && empty(PKG_OPTIONS:Mkerberos)
-PKG_OPTIONS+=		kerberos
+.if !empty(PKG_OPTIONS:Mgssapi)
 CONFIGURE_ARGS+=	--with-gssapi=${KRB5BASE}
 .else
 CONFIGURE_ARGS+=	--with-gssapi=no
@@ -40,7 +39,7 @@
 ###
 ### Kerberos V support.
 ###
-.if !empty(PKG_OPTIONS:Mkerberos)
+.if !empty(PKG_OPTIONS:Mkerberos) || !empty(PKG_OPTIONS:Mgssapi)
 .  include "../../mk/krb5.buildlink3.mk"
 PKG_USE_KERBEROS=	# defined
 CONFIGURE_ARGS+=        --with-kerberos5=${KRB5BASE}

--96YOpH+ONegL0A3E--