--Apple-Mail-3--1072017473
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=US-ASCII;
	format=flowed

> Why?

Because bsd.pkg.mk is currently "broken". Which breaks at least libxml2 
and shared-mime-info. A fix for bsd.pkg.mk is attached. (I'm waiting 
for tv's approval to commit it.)

> It was quite difficult for me to convince the mainstream developers to
> support changing the default catalog files on an out-of-the-box build,
> without having to patch the sources.  But at last I got it:
>
> 	http://bugzilla.gnome.org/show_bug.cgi?id=104475
>
> The less patches we have to maintain, the better;  and that was my
> original intention.

That's correct the lesser patches the better.

> So... this should be reverted.  If there is a real problem in how it

Hmm, the libxml2 makes it pretty clear that he won't take your 
configure patch -- I don't understand why, though. The reason why I'd 
like to keep the patches is that "-D" is not available with all 
compilers out there. (Or we revive your configure patch.)

> works (and is not our fault), a bug should be filled against libxml2.


Cheers,
Marc



--Apple-Mail-3--1072017473
Content-Transfer-Encoding: 7bit
Content-Type: application/octet-stream;
	x-unix-mode=0644;
	name="bsd.pkg.mk.diff"
Content-Disposition: attachment;
	filename=bsd.pkg.mk.diff

Index: bsd.pkg.mk
===================================================================
RCS file: /cvsroot/pkgsrc/mk/bsd.pkg.mk,v
retrieving revision 1.1587
diff -u -u -b -r1.1587 bsd.pkg.mk
--- bsd.pkg.mk	12 Feb 2005 00:27:41 -0000	1.1587
+++ bsd.pkg.mk	12 Feb 2005 17:57:24 -0000
@@ -284,15 +284,15 @@
 .endif
 
 ALL_ENV+=	CC=${CC:Q}
-ALL_ENV+=	CFLAGS=${CFLAGS:Q}
-ALL_ENV+=	CPPFLAGS=${CPPFLAGS:Q}
+ALL_ENV+=	CFLAGS="${CFLAGS}"
+ALL_ENV+=	CPPFLAGS="${CPPFLAGS}"
 ALL_ENV+=	CXX=${CXX:Q}
-ALL_ENV+=	CXXFLAGS=${CXXFLAGS:Q}
+ALL_ENV+=	CXXFLAGS="${CXXFLAGS}"
 ALL_ENV+=	COMPILER_RPATH_FLAG=${COMPILER_RPATH_FLAG:Q}
 ALL_ENV+=	F77=${F77:Q}
 ALL_ENV+=	FC=${FC:Q}
-ALL_ENV+=	FFLAGS=${FFLAGS:Q}
-ALL_ENV+=	LDFLAGS=${LDFLAGS:Q}
+ALL_ENV+=	FFLAGS="${FFLAGS}"
+ALL_ENV+=	LDFLAGS="${LDFLAGS}"
 ALL_ENV+=	LINKER_RPATH_FLAG=${LINKER_RPATH_FLAG:Q}
 ALL_ENV+=	PATH=${PATH:Q}:${LOCALBASE}/bin:${X11BASE}/bin
 ALL_ENV+=	PREFIX=${PREFIX}

--Apple-Mail-3--1072017473--