Subject: Re: CVS commit: pkgsrc/chat/xchat
To: Matthias Scheler <tron@netbsd.org>
From: Julio M. Merino Vidal <jmmv@menta.net>
List: pkgsrc-changes
Date: 10/07/2004 14:51:49
On Thu, Oct 07, 2004 at 09:05:27AM +0000, Matthias Scheler wrote:
> 
> Module Name:	pkgsrc
> Committed By:	tron
> Date:		Thu Oct  7 09:05:27 UTC 2004
> 
> Modified Files:
> 	pkgsrc/chat/xchat: Makefile.common
> 
> Log Message:
> We don't need to include "../../devel/glib/buildlink3.mk" explicitly here
> because "x11/gtk/buildlink3.mk" does that for us.

This change is, IMHO, incorrect.  xchat uses the glib library directly,
so it needs a direct dependency on glib.  With this change, glib becomes
an indirect dependency.  This kind of changes were correct before the
recursive registration of dependencies was removed...

Cheers

-- 
Julio M. Merino Vidal <jmmv@menta.net>
The NetBSD Project - http://www.NetBSD.org/