Subject: Re: CVS commit: pkgsrc/devel/ncurses
To: Matthias Drochner <M.Drochner@fz-juelich.de>
From: grant beattie <grant@netbsd.org>
List: pkgsrc-changes
Date: 07/10/2004 10:18:48
--mxv5cy4qt+RJ9ypb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jul 09, 2004 at 03:35:11PM +0200, Matthias Drochner wrote:

> Well, it builds, but it does not install cleanly. It tries to
> filter some manpages trough "tbl". (This is explicitely
> enabled though a CONFIGURE_ARG.)

my repeated bulk builds on Solaris beg to differ - there was a time
when ncurses did not build on Solaris but that was a long time ago. I
haven't seen any kind of ncurses build or install lossage in ages.

what was your motivation for adding this? what systems do not have
tbl(1)? the commit message was not exactly descriptive.

Solaris has tbl(1), so don't sledgehammer a groff dependency on it when
it isn't needed. groff/buildlink3.mk should only be included if groff
is *required*.

> > this also introduces a dependency
> > on a c++ package very low down in the dependency tree
>=20
> It is only a BUILD_DEPEND, and even that only on systems
> where it is not in the base system.

which is a number of our platforms, and I'm still very unhappy about a
c++ dependency this low down in the tree. please remove this
unnecessary dependency.

> > add a distinction between
> > requiring nroff(1) and groff(1)
>=20
> Do you have any ideas how groff/builtin.mk should be
> extended for this? (Extending tools.mk as proposed
> is also an option.)

as tbl(1) is just one program from a suite of programs, I'm not sure
how best to handle this - the tools.mk stuff mostly deals with
situations where a package is largely providing a tool, not
providing a whole suite. there is probably no reason why you couldn't
add tbl to the list of tools and pull in groff if tbl isn't available,
but I'm not sure I can think of a situation where that would be
needed.

grant.


--mxv5cy4qt+RJ9ypb
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (NetBSD)

iD8DBQFA7zXoluYOb9yiFXoRAvm6AJ9HZIdxtbhbCldo0HdL5tPlum3VmQCfcf+Q
T/1ZpxpQ+FTM6GwxTm67x5s=
=Flas
-----END PGP SIGNATURE-----

--mxv5cy4qt+RJ9ypb--