Subject: Re: CVS commit: pkgsrc
To: None <tech-pkg@NetBSD.org, packages@NetBSD.org>
From: Jim Wise <jwise@draga.com>
List: pkgsrc-changes
Date: 06/15/2004 12:36:07
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tue, 15 Jun 2004, Matthias Drochner wrote:

>
>Module Name:	pkgsrc
>Committed By:	drochner
>Date:		Tue Jun 15 16:17:48 UTC 2004
>
>Modified Files:
>	pkgsrc/lang/tcl: Makefile buildlink3.mk
>	pkgsrc/x11/tk: Makefile buildlink3.mk
>
>Log Message:
>Don't --enable-threads for now. If we do this, all potential users of
>libtcl.so/libtk.so (whether linking it in or dlopen() it) must be linked
>against libpthread. This is something we can't guarantee.
>Fixes bulk build error in py-imagingtk and numerous runtime problems.

I am reversing this change.

With this change, tcl is _not_ usable in threaded apps, while without
this change, tcl is perfectly usable in non-threaded apps.

The fix for a package which is incorrectly written is not to break the
package it depends on, but do your job correctly when writing the
package.

With buildlink3, this is mind-numbingly easy to do.

That you neither contacted the maintainer of this package, nor did the
buildlink and dependent package changes which your change requires shows
that you have not really thought this through.

So, as I said, I am reversing this change.  Fix your own package, don't
break others.

- -- 
				Jim Wise
				jwise@draga.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (NetBSD)

iD8DBQFAzyV6RxzMSZ/9vAMRAoOIAKCZXkpacSkGh4hVnd+mMjIh4x02LgCfVgjy
24cwQFeoMv3omD7yN8qy75c=
=QgHe
-----END PGP SIGNATURE-----