--Signature=_Mon__14_Jun_2004_23_18_59_+0200_SBDv3pRt23+/6097
Content-Type: text/plain; charset=US-ASCII
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

Le Tue, 15 Jun 2004 07:10:59 +1000
grant beattie a ecrit :
> On Mon, Jun 14, 2004 at 08:51:11PM +0000, Quentin Garnier wrote:
> 
> > Module Name:	pkgsrc
> > Committed By:	cube
> > Date:		Mon Jun 14 20:51:11 UTC 2004
> > 
> > Modified Files:
> > 	pkgsrc/databases/postgresql74: Makefile.common
> > 
> > Log Message:
> > 'localedir' is actually two spaces away from the beginning of the line
> > in the configure script.  Let's play safe and use '\s+'.  Should fix
> > PR 25923 by jmmv.
> 
> forgive me, it's early and I lack caffeine, however, I don't see how
> this is the cause of the problem described in the PR, or how \s+ will
> fix it.

It clearly is the lack of caffeine.  I fail to see how this can seem
complicated, but the very purpose of that SUBST block is to replace a line
in the configure script that affects the localedir variable to an empty
value by the correct one.  This is explained in the comment just before
the SUBST block.

Problem is, there wasn't enough spaces in the sed expression, so the SUBST
block did nothing, and localedir stayed empty.  Then locale files get
installed in /.

> did you test this? I didn't think we could use anything more than BREs
> in SUBST_SED stuff.

Yes, I've tested it, however only on NetBSD.  It's hard to keep track of
what is allowed and what is not depending on your platform of the day, and
if next time the PostgreSQL run autoconf it adds a space we'll have to
debug this again.

-- 
Quentin Garnier - cube@cubidou.net - cube@NetBSD.org
"Feels like I'm fiddling while Rome is burning down.
Should I lay my fiddle down and take a rifle from the ground ?"
Leigh Nash/Sixpence None The Richer, Paralyzed, Divine Discontents, 2002.

--Signature=_Mon__14_Jun_2004_23_18_59_+0200_SBDv3pRt23+/6097
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (NetBSD)

iQEVAwUBQM4WSNgoQloHrPnoAQIb8QgAj528CkS1r/8Re+HbKJJ//PQSWLXyqQ78
c//4rc8gdn6ka//mNstnGoFt/22e+pSoCb9NmeI3JULaISbj1y/MDyEiGPyeEnRF
DLbI4VZKNkwKprgSKlqPnPC8eNEkJ6TtSQa0QgqEmLzvTkEODFl2fj2ExJVglu8c
rKpHx7PIKSUtsh2L/o9MHjoGOu+cQBJJldnTXeqZz/o9C2bOz8iagOjQ3KvA3y4F
yFu0hHoTPYIqAGauu+mm3c9JabcQOWMdhBbFHbFalQ2aCC6seMzwRFxkWVp7wPmL
5KgfZ7rwdcoltnX60uhMZ9zIX5NCNy+5UG7k641Gw6fzx2YHecA6aQ==
=o/VX
-----END PGP SIGNATURE-----

--Signature=_Mon__14_Jun_2004_23_18_59_+0200_SBDv3pRt23+/6097--