Subject: Re: CVS commit: pkgsrc/audio/bmp
To: Juan RP <juan@xtraeme.unixbsd.org>
From: Lubomir Sedlacik <salo@Xtrmntr.org>
List: pkgsrc-changes
Date: 04/14/2004 15:29:04
--dFvuq/4WPi1dbS7Q
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

hi,

On Wed, Apr 14, 2004 at 03:21:53PM +0200, Juan RP wrote:
> On Wed, 14 Apr 2004 15:14:20 +0200 Lubomir Sedlacik wrote:
> >
> > could you please tell me what was the point in upgrading this
> > package?
> >=20
> > as stated in the PR:
> >=20
> >  "I've diffed bmp 0.9.6 and 0.9.6.1, the changes are very very
> >  minimal, they've just incorporated patch-af, so it's no longer used
> >  and thus removed by my patch"
> >=20
> > now we have two identical packages with different version numbers,
> > confused people who upgrade for no reason, waster space on ftp,
> > unnecessary revisions in cvs, just for a sake of "blindly committing
> > a random from a PR".
> >=20
> > did you even bother to read the PR trail before committing?
>=20
> Why do you mean both version are the same? if patch-af was added into
> the new version, they aren't... right?=20

the package you install from both versions will be the same, there is no
difference in having patch-af in our repository or being incorporated in
the upstream distribution.  the only difference between these two
packages is the version number.

different version number means:

- distfile is stored on ftp.NetBSD.org and its mirrors (wasted space)
- (possible) packages build from both versions will be stored on
  ftp.NetBSD.org and its mirrors (again, wasted space)
- unnecessary revisions in cvs, and all the related things (mirrors,
  cvsweb, ...)
- people will think the package is different and thus upgrade
- etc.

of course, most of these are not critical but it makes a bad precedent.

> What's wrong on closing PRs?

there is nothing wrong in closing PRs.  this PR should have been closed,
without applying the patch.  blindly applying patches from PRs and
closing them, on the other hand _is_ wrong.


regards,

--=20
-- Lubomir Sedlacik <salo@{NetBSD,Xtrmntr,silcnet}.org>   --

--dFvuq/4WPi1dbS7Q
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (NetBSD)

iD8DBQFAfTygiwjDDlS8cmMRAqlhAJ0WE78Xr0nIgUbOyoJ4w+vCEeyhLQCfXrd0
KkasLxCiylG0fvNwhRg2IR8=
=54e6
-----END PGP SIGNATURE-----

--dFvuq/4WPi1dbS7Q--