Subject: CVS commit: pkgsrc/net/ppp-mppe
To: None <pkgsrc-changes@NetBSD.org>
From: Quentin Garnier <firstname.lastname@example.org>
Date: 12/01/2003 15:07:03
Module Name: pkgsrc
Committed By: cube
Date: Mon Dec 1 15:07:03 UTC 2003
Comment out the code that returned DECOMP_ERROR when an out-of-order packet
is received. It is necessary because in the case of a dropped packet,
while it is understandable to return DECOMP_ERROR, it has the side effect
of making NetBSD desactivate the MPPE decompressor on the PPP interface.
A comment in net/if_ppp.c mentions a patent that would prohibit an
automatic failure recovery in that case, so it would need MPPE-specific
code in net/if_ppp.c, which of course is impossible since the MPPE
decompressor is only available as a LKM.
Just ignoring the problem is a bit of a hack, but is a much more nicer
solution that what I used when I first encountered the issue.
Problem reported and patch provided in PR 23593, by Yoshitaka Tokugawa.
To generate a diff of this commit:
cvs rdiff -r1.3 -r1.4 pkgsrc/net/ppp-mppe/distinfo
cvs rdiff -r188.8.131.52 -r1.2 pkgsrc/net/ppp-mppe/patches/patch-bt
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.