Subject: CVS commit: pkgsrc/mk/bulk
To: None <pkgsrc-changes@NetBSD.org>
From: Hubert Feyrer <hubertf@netbsd.org>
List: pkgsrc-changes
Date: 10/10/2003 21:45:55
Module Name:	pkgsrc
Committed By:	hubertf
Date:		Fri Oct 10 21:45:55 UTC 2003

Modified Files:
	pkgsrc/mk/bulk: bsd.bulk-pkg.mk

Log Message:
This patch addresses three problems:

1) When checking if any of the required binary pkgs is newer, it's
   not good to look into the (already existing) binary pkg, as that
   might be unchanged. Instead, look at the DEPENDS.

   In the context of the recent jpeg changes, the gd package itself was
   not changed, but the DEPENDS were (via buildlink files). Now looking
   into the existing gd binary pkg still said it wanted jpeg-6b instead
   of the now-wanted jpeg>=6b, which was only available via the DEPENDS.

   That's the first chunk of the patch below.

2) While debugging this, I found that the change in rev. 1.48 was
   wrong, as can be seen throughout the last bulk build, search for errors
   like:

	find: "/usr/cvs.local/pkgsrc/packages/i386/All/gd-2.0.15.tgz": No such file or directory

   As the whole operation is really on two files (as assured by "pkg_admin
   lsbest" for pkg and REFS by definition), the quotes can be ommitted.

   Why this wasn't caught when that change was tested is beyond me - maybe
   different sh(1) behaviour? (The error happened on 1.6.1_STABLE, see
   e.g. http://smaug.fh-regensburg.de/~feyrer/ftp/pub/NetBSD/pkgstat-i386/last/www/p5-Template-Toolkit/.broken.yui.html).

   Anyways, that's addressed in the second part of the patch below, too.

3) Use ${FIND} while there.


To generate a diff of this commit:
cvs rdiff -r1.49 -r1.50 pkgsrc/mk/bulk/bsd.bulk-pkg.mk

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.