Subject: Re: CVS commit: pkgsrc/mk
To: Lubomir Sedlacik <salo@Xtrmntr.org>
From: grant beattie <grant@netbsd.org>
List: pkgsrc-changes
Date: 03/08/2003 23:22:46
On Sat, Mar 08, 2003 at 12:45:40PM +0100, Lubomir Sedlacik wrote:

> i think we have PKG_SYSCONFDIR and converting all packages to this
> framework for a reason and making such an unnecessary diversity is
> harmful.  those who want cdrecord.conf in /etc/default/cdrecord can set
> PKG_SYSCONFDIR.cdrecord to /etc/default/cdrecord in their /etc/mk.conf.

unfortunately, that does not provide the same result. it is, however,
influenced by PKG_SYSCONFDIR{,.cdrecord}.

> CDRECORD_CONF is superfluous, please back out this change and fix
> cdrecord to directly use PKG_SYSCONFDIR.  thanks.

it is not superfluous at all. it provides a clean way to allow users
to use the previous default (or any other path) if they so desire.

other packages use very similar semantics for users to tweak
paths, and this is appropriate given the author's intentions.

if there is a concern with exposing the variable in
bsd.pkg.defaults.mk, I don't have any big objection to removing
it from there - it's commented out, anyway!

g.